--- Log opened Thu Mar 08 00:00:02 2012
06:55 < conseo> mcallan: can i embed the diffmessagetable class privately to keep the sql stuff separate from the rest of Cache?
07:00 < conseo> or do you want me to do it directly in the read() and store() methods?
07:31 < mcallan> looking...
07:31 < mcallan> http://whiletaker.homeip.net/votorola/harvester/javadoc/votorola/a/diff/harvest/DiffMessageTable.html
07:36 < mcallan> conseo: myself i would just use the table class (renaming it), if that's really the api onto the database.  looks like it is.  unless there's more to it, e.g. the api spans *multiple* tables,  then it's a trickier q what to do
07:37 < mcallan> if any of the methods are private to the table class (not part of api), then i would just make them private
07:52 < conseo> the Cache is more than the DB, it also checks whether messages are valid and talks to the voteserver to parse the difference information
07:58 < conseo> well, i don't care to mix the sql commands in, i just thought that sql stuff would be hidden by a wrapper *Table
08:01 < mcallan> cache is more than the table... yes, i guess yer right.  so you can put the table class anywhere, including top level.  it's up to you
08:03 < mcallan> (i would put at top, just because it's important, even tho it's not in the arch diagram - still important)
08:04 < conseo> mcallan: i can make it package private and just expose the read/store calls from Cache
08:06 < mcallan> conseo: i wouldn't write a bunch of empty methods that just call methods.  instead your original api was best: just expose it as Cache.diffMessageTable or whatever
08:07 < conseo> hmm, ok. but store() is still a Cache routine (because it has to parse the diff information)
08:07 < conseo> would i make DiffMessageTable.put() public then still?
08:08 < conseo> i tend to make everything private i can
08:09 < mcallan> right, make everything public that needs to be, and nothing else.
08:10 < conseo> ok
08:10 < mcallan> it's ok to have Cache.store() instead of Cache.table().store() if you want to reserve table for low level stuff.  your call
08:10 < mcallan> (meaning your choice)
08:14 < conseo> good, thx
08:45 < conseo> mcallan: "Administrative configuration on server". This would be a JavaScript ConstructionContext in HarvestCache?
08:46 < conseo> the only thing i need (for the Pipermail harvester) is access to the Wiki to get all the forum configs
08:46 < conseo> i would like to keep it that way as a good default until we really need server side configs
08:46 < mcallan> ok
08:46 < conseo> (and you have proposed it that way ofc.)
08:47 < conseo> do i need a config for that or can i get that from the voteserver config? i guess so. so i would construct a voteserver for the user running the harvester and be done (without config file)
08:51 < mcallan> sounds right
09:01 < mcallan> i'm off c, cu later
09:10 < conseo> ok, n8
09:10 < conseo> cu
12:47 < conseo> mcallan: wanted to play around with semantic queries a bit, hit an internal error:
12:47 < conseo> "Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information."
12:47 < conseo> page was: http://zelea.com/w/Special:Ask
12:48 < conseo> time in last 3 mins
14:34 < conseo> so utc around 17:45+
19:25 < mcallan> conseo: i've been seeing that for maybe a year now.  i think it's an smw bug in their postrgres support
19:26 < mcallan> (postgres)
--- Log closed Fri Mar 09 00:00:18 2012