--- Log opened Sat Jul 30 00:00:39 2011 07:48 < mcallan> there, it's posted: http://listserv.aoir.org/pipermail/air-l-aoir.org/2011-July/024104.html 07:49 < mcallan> if it doesn't get shot down, i can focus on coding from now on 14:17 < mcallan> conseo: your changeset 632:5016ce3eff69 replaces FileX.renameFromDefaultToMv with a copy/delete routine. It is not actually a 'mv', so it shouldn't be called that. I thought you were only going to change the "renameTo calls to renameFromDefaultMv", which is what I agreed to. http://zelea.com/var/cache/irc/votorola/11-07/24 14:21 < mcallan> in general, i think we shouldn't fix what isn't broken. i just wrote that code, and it was working fine. can you limit the fix to the wiki cache, which is where the fault was? 14:33 < mcallan> (btw it's ok to add a new method renameFromDefaultsToCopyDelete and use that to fix the wiki cache, but i wouldn't replace old calls that were working fine - i guess that's all i meant to say) 15:13 < conseo> mcallan: i have replaced it since the copy routine is used by mv anyway if java.io.File.renameTo does not work (we are not on the same filesystem) 15:13 < conseo> mcallan: this works on non posix system as well, while mv only works on *nix systems 15:15 < conseo> if you call mv FILESYSTEM1/file FILESYTEM2/new_file it will copy and delete 15:16 < conseo> (i said that as well and you were not denying it, so i thought the java routine would be best) 15:16 < conseo> (or what we agreed upon) sorry not to explicetly ask again 15:30 < mcallan> i wasn't clear enough, my fault. we end up wasting time over nothing. yes it's definitely ok to fix the wiki cache's renameFrom, because it was broken. there's no need to ask about that kind of thing, because the fix doesn't (shouldn't) affect any other code 15:32 < mcallan> but to save time, it's best not to fix stuff that isn't broken (i.e. the DiffCache's rename call). then there's no need to talk about it, and we would have saved all this time. 15:33 < mcallan> but i can live with the change this time... no prob 15:34 < conseo> mcallan: http://java.sun.com/developer/technicalArticles/javase/nio/#5 15:35 < conseo> we can also replace the explicit call to "ln" in the FileX code with this, so we would be OS transparent 15:35 < conseo> i just thought that it might make sense to stick to java stuff to stick to the JVM layer instead of specific command line tools 15:36 < conseo> but maybe you want to call command line tools anyway and don't expect this code to run on windows * systems for example anyway 15:36 < conseo> but keeping it in java somehow appealed to me as a rule of thumb 15:46 < conseo> mcallan: is this argument flawed/the discussion not worth it? 15:47 < mcallan> i don't know c, my aim is to avoid wasting time... is this a serious issue? 15:48 < mcallan> i am replying to your diff feed message, and i only have so much time. you too, you only have so much time. 15:48 < conseo> sure 15:51 < conseo> this answer is more important than this 15:52 < conseo> mcallan: tell me when you are finished, because i won't change the code before not being sure what is about to come out 15:58 < mcallan> i don't understand c, finished what? i have about 30 minutes, will it save time if we skype? 16:00 < mcallan> skype box starting... 16:01 < conseo> i just meant your answer to the list about the diff-feed implementation is more important than some filesystem calls 16:01 < conseo> mcallan: sorry if i was unclear 16:02 < mcallan> it's ok, i'm a little wasted. i'll post what i've written, let's skype about the rest... 16:02 < conseo> ok --- Log closed Sun Jul 31 00:00:55 2011